Skip to content

feat: replace alpine with ubuntu - #2699

Draft
RohitKushvaha01 wants to merge 2 commits into
Acode-Foundation:mainfrom
RohitKushvaha01:ubuntu
Draft

feat: replace alpine with ubuntu#2699
RohitKushvaha01 wants to merge 2 commits into
Acode-Foundation:mainfrom
RohitKushvaha01:ubuntu

Conversation

@RohitKushvaha01

@RohitKushvaha01 RohitKushvaha01 commented Aug 8, 2026

Copy link
Copy Markdown
Member

No description provided.

@RohitKushvaha01 RohitKushvaha01 self-assigned this Aug 8, 2026
@RohitKushvaha01
RohitKushvaha01 marked this pull request as draft August 8, 2026 06:55
@github-actions github-actions Bot added translations Anything related to Translations Whether a Issue or PR docs labels Aug 8, 2026
@greptile-apps

greptile-apps Bot commented Aug 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR replaces the bundled Alpine terminal runtime with Ubuntu and updates the native executor, document provider, terminal lifecycle, LSP runtime provider, package installation commands, assets, settings, and localization terminology.

  • Ships Ubuntu root filesystems for supported Android architectures and rewires terminal installation, execution, backup, and process metadata around ubuntu/.
  • Renames the built-in LSP runtime and converts managed server installation from apk to apt.
  • Updates the document provider and public-facing Alpine terminology, but leaves legacy backup compatibility incomplete.

Confidence Score: 4/5

The PR should not merge until legacy terminal restores are either migrated to Ubuntu or explicitly rejected instead of reporting a successful but unusable restore.

The new restore implementation accepts old Alpine archives, extracts them successfully, and then fails the current ubuntu/-based installation check and launch path; the remaining findings are non-blocking documentation and diagnostic inaccuracies.

Files Needing Attention: src/plugins/terminal/www/Terminal.js, fastlane/metadata/android/en-US/full_description.txt, src/cm/lsp/servers/luau.ts

Important Files Changed

Filename Overview
src/plugins/terminal/www/Terminal.js Migrates installation, backup, restore, and runtime paths to Ubuntu, but legacy Alpine backups can be accepted as successfully restored while remaining unusable.
src/plugins/terminal/scripts/init-sandbox.sh Repoints PRoot setup and shared-directory migration to the Ubuntu root filesystem.
src/plugins/terminal/scripts/init-ubuntu.sh Converts initial package setup and terminal initialization from Alpine/apk to Ubuntu/apt.
src/cm/lsp/serverLauncher.ts Converts generated LSP install and uninstall commands to apt and updates Ubuntu runtime paths.
src/cm/lsp/servers/luau.ts Updates terminology but introduces an inaccurate Ubuntu/musl failure diagnostic.
fastlane/metadata/android/en-US/full_description.txt Renames the advertised terminal to Ubuntu while incorrectly retaining apk usage instructions.
src/plugins/terminal/src/android/ProcessManager.java Renames the sandbox selection flag to Ubuntu without materially changing the pre-existing shell execution behavior.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  Install[Terminal install] --> Rootfs[Extract Ubuntu rootfs]
  Rootfs --> Sandbox[init-sandbox.sh]
  Sandbox --> Ubuntu[init-ubuntu.sh]
  Ubuntu --> Executor[Terminal and background commands]
  LSP[LSP runtime provider] --> Executor
  Backup[Backup or restore] --> Rootfs
  Legacy[Legacy Alpine backup] -->|currently extracted without migration| Inert[Unused alpine directory]
Loading

Comments Outside Diff (2)

  1. src/plugins/terminal/www/Terminal.js, line 502 (link)

    P1 Legacy backups restore unusably

    When a user restores an Alpine-era aterm_backup.tar, this path extracts the legacy alpine/ layout and reports success, but the current installation check and launcher require ubuntu/, leaving the terminal unavailable. Migrate the legacy layout during restore or reject incompatible backups before reporting success.

    Knowledge Base Used: Plugin System

  2. src/cm/lsp/servers/luau.ts, line 36 (link)

    P2 Diagnostic misidentifies Ubuntu libc

    The changed Luau diagnostic describes Ubuntu as a musl environment, giving users contradictory runtime information and obscuring the actual cause when the executable check reports a linker or GLIBC failure.

    Knowledge Base Used: LSP Integration

Reviews (1): Last reviewed commit: "feat: replace alpine with ubuntu" | Re-trigger Greptile

greptile-apps[bot]
greptile-apps Bot reviewed Aug 8, 2026
View reviewed changes
Comment thread fastlane/metadata/android/en-US/full_description.txt Outdated
@RohitKushvaha01 @greptile-apps
Update fastlane/metadata/android/en-US/full_description.txt
aa3292a 
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@ardyt647

ardyt647 commented Aug 8, 2026

Copy link
Copy Markdown

Bro ubuntu is very heavy for lowend devices. instead of ubuntu we should use debain which same as ubuntu but lightweight

@RohitKushvaha01

RohitKushvaha01 commented Aug 8, 2026

Copy link
Copy Markdown
Member Author

Bro ubuntu is very heavy for lowend devices. instead of ubuntu we should use debain which same as ubuntu but lightweight

Debian rootfs is around 70mb+ meanwhile the ubuntu rootfs is around 35mb+

@ardyt647

ardyt647 commented Aug 8, 2026

Copy link
Copy Markdown

Bro I am taking about performance not how much storage it needs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Assignees

@RohitKushvaha01 RohitKushvaha01

Labels

docs translations Anything related to Translations Whether a Issue or PR

Projects

The Code Board - Acode
Status: Backlog

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RohitKushvaha01 @ardyt647